about Thievery Losses

[Bijo]

can someone plz verify that Thievery Losses are 99% max

http://img141.imageshack.us/img141/1106/buildingfl4.png

(i am sure it is right but i never checked)

[Toadi]

Yes.

Your two "if" sections are massively redundant you might want to code this properly :P

[Bijo]

its not massively redundant i just added all the checks for the 99% so i can put all the buildings modifiers in variables so that if and when OMAC will change them it will be much easier to change them

plus its easier to read it like that because its going to be open code and i am trying to make it as clearly as i can

i am going to put all buildings modifiers in variables soon and this is why its looks like that

if you think its funny or redundant as you put it its not my problem
this is just the way to write a code properly thats all

and thx for replying that it was 99% :)

[Toadi]

If this is how you think code should be written properly, then I truly hope you are not going to work as a developer. Functions do exist for a reason. Why don't you use a single function that would be called for performing all the values checks? If tomorrow OMAC changes building maximum to 98% reached for 20% of land, you have 20 lines to fix. This is not a code that can be easily maintained.

[Bijo]

If this is how you think code should be written properly, then I truly hope you are not going to work as a developer. Functions do exist for a reason. Why don't you use a single function that would be called for performing all the values checks? If tomorrow OMAC changes building maximum to 98% reached for 20% of land, you have 20 lines to fix. This is not a code that can be easily maintained.

and who says i am not gonna?
first i am writing it all down
then i am will see what i can put in functions
this is easier to see this way
plus if you would have checked i already started to put functions on some part of the code but you didnt checked so you are just trying to argue with me again or somthing like that... which is not cool!

[Bijo]

If tomorrow OMAC changes building maximum to 98% reached for 20% of land, you have 20 lines to fix. This is not a code that can be easily maintained.

i just wanted to add that if you were smart you would know you cant write all the functions line less then the number of buildings!!!

and as for the 99% i am simply going to put it into a variable as well
so you dont need to put it into functions!

owned!!! :)

[waheed]

wow...

[Arkangel]

whatever

[VT2]

Bijo sucks as always, and no one's surprised or impressed, but some may be awed.

[Raywre]

VT2 sucks as always, and no one's surprised or impressed, but some may be awed.

[Bijo]

VT2 sucks as always, and no one's surprised or impressed, but some may be awed.

Raywre just do what i do and ignore VT2 its the best way to go trust me on that ;)

[Sashdev]

Lets not get into unnecessary fights, shall we?!

[Arkangel]

why not? i would stop reading forums when i'm bored if there wasn't the fights.

[Phunky]

Sometimes Bijo's spam is annoying, other times it is highly amusing. The self ownage he sometimes puts himself through is unbeatable.

[Astares]

half of my desire to read these forums is the possibility of watching unnecessary fights. I read the comments while relating the participants to various tv characters. It's quite amusing.

Catwalk = Batman
VT2 = Robin
vines = the little chickenhawk from the looney tunes